-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php: builder #286
php: builder #286
Conversation
Since we are reading composer.lock, assume that missing requirements are satisfied in upper packages by provides/replaces
trim did not work correctly for version ranges: 5.0 - 5.8 5.0 - 5.8 | 6.* | ^7.1
4d023a7
to
b2269bd
Compare
Tested on https://github.com/composer/composer, build and devShell both work as expected. |
Co-authored-by: Brian Leung <[email protected]>
That should not be necessary. You can add the example flake under /examples/php/flake.nix, and then execute from the repo root: Alternatively navigate to /examples/php, then run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all that valuable work. Just a few suggestions here.
I just added an example via e77c129. Working fine. |
It seems like the composer example adds significant overhead to the test execution. |
@DavHau
But does not seem to have any effect on the CI time. |
Thanks for this, I recently tried this builder on one of the projects but got this error:
The project composer.json uses aliases as described here: |
@aszenz |
Sure here's a sample project on which running https://github.com/aszenz/php-app-nix If i remove the |
Towards #240
Disable packagist.org repo for composer, use artifact or path repositories.